[Mlir-commits] [mlir] [MLIR] Remove deprecated setting usePropertiesForAttributes (PR #182327)

[Matthias Springer]

================
@@ -570,20 +570,14 @@ class RegisteredOperationName : public OperationName {
         return ConcreteOp::getInherentAttr(concreteOp->getContext(),
                                            concreteOp.getProperties(), name);
       }
-      // If the op does not have support for properties, we dispatch back to the
-      // dictionnary of discardable attributes for now.
-      return cast<ConcreteOp>(op)->getDiscardableAttr(name);
+      return std::nullopt;
----------------
matthias-springer wrote:

Same here, should this be a failed assertion?
`static_assert(hasProperties)`

https://github.com/llvm/llvm-project/pull/182327