[Mlir-commits] [mlir] b0192c3 - [mlir][spirv] (De)serialize Offset, XfbBuffer and XfbStride decorations (#181835)

[llvmlistbot at llvm.org]

Author: moscickimilosz
Date: 2026-02-19T13:47:57Z
New Revision: b0192c31a17f263b77d2eed5fbdab3a95a4e8edc

URL: https://github.com/llvm/llvm-project/commit/b0192c31a17f263b77d2eed5fbdab3a95a4e8edc
DIFF: https://github.com/llvm/llvm-project/commit/b0192c31a17f263b77d2eed5fbdab3a95a4e8edc.diff

LOG: [mlir][spirv] (De)serialize Offset, XfbBuffer and XfbStride decorations (#181835)

Process decorations number 35, 36 and 37 in SPIR-V deserializer and
serializer; add a simple test case.

Added: 
    

Modified: 
    mlir/lib/Target/SPIRV/Deserialization/Deserializer.cpp
    mlir/lib/Target/SPIRV/Serialization/Serializer.cpp
    mlir/test/Target/SPIRV/decorations.mlir

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Target/SPIRV/Deserialization/Deserializer.cpp b/mlir/lib/Target/SPIRV/Deserialization/Deserializer.cpp
index 933433bcaa57a..e218bee4b4fe3 100644
--- a/mlir/lib/Target/SPIRV/Deserialization/Deserializer.cpp
+++ b/mlir/lib/Target/SPIRV/Deserialization/Deserializer.cpp
@@ -288,6 +288,9 @@ LogicalResult spirv::Deserializer::processDecoration(ArrayRef<uint32_t> words) {
   case spirv::Decoration::Location:
   case spirv::Decoration::SpecId:
   case spirv::Decoration::Index:
+  case spirv::Decoration::Offset:
+  case spirv::Decoration::XfbBuffer:
+  case spirv::Decoration::XfbStride:
     if (words.size() != 3) {
       return emitError(unknownLoc, "OpDecorate with ")
              << decorationName << " needs a single integer literal";

diff  --git a/mlir/lib/Target/SPIRV/Serialization/Serializer.cpp b/mlir/lib/Target/SPIRV/Serialization/Serializer.cpp
index d9ffc4131d3c3..c21cb27b072f1 100644
--- a/mlir/lib/Target/SPIRV/Serialization/Serializer.cpp
+++ b/mlir/lib/Target/SPIRV/Serialization/Serializer.cpp
@@ -339,6 +339,9 @@ LogicalResult Serializer::processDecorationAttr(Location loc, uint32_t resultID,
   case spirv::Decoration::DescriptorSet:
   case spirv::Decoration::Location:
   case spirv::Decoration::Index:
+  case spirv::Decoration::Offset:
+  case spirv::Decoration::XfbBuffer:
+  case spirv::Decoration::XfbStride:
     if (auto intAttr = dyn_cast<IntegerAttr>(attr)) {
       args.push_back(intAttr.getValue().getZExtValue());
       break;

diff  --git a/mlir/test/Target/SPIRV/decorations.mlir b/mlir/test/Target/SPIRV/decorations.mlir
index f64d113ebba9d..94c2724c3d9ed 100644
--- a/mlir/test/Target/SPIRV/decorations.mlir
+++ b/mlir/test/Target/SPIRV/decorations.mlir
@@ -91,6 +91,15 @@ spirv.module Logical GLSL450 requires #spirv.vce<v1.0, [Shader, Linkage], []> {
 
 // -----
 
+spirv.module Logical GLSL450 requires #spirv.vce<v1.0, [Shader, Linkage, TransformFeedback], []> {
+  // CHECK: offset = 0
+  // CHECK-SAME: xfb_buffer = 0
+  // CHECK-SAME: xfb_stride = 112
+  spirv.GlobalVariable @spirv_var_64 {offset = 0 : i32, xfb_buffer = 0 : i32, xfb_stride = 112 : i32} : !spirv.ptr<vector<3xf32>, Output>
+}
+
+// -----
+
 spirv.module Logical GLSL450 requires #spirv.vce<v1.0, [Shader, Linkage], []> {
   // CHECK: linkage_attributes = #spirv.linkage_attributes<linkage_name = "outSideGlobalVar1", linkage_type = <Import>>
   spirv.GlobalVariable @var1 {