[Mlir-commits] [mlir] [mlir][tosa] Refactor convolution infer return type (PR #178869)

[Iliyan Georgiev]

================
@@ -3435,162 +3435,241 @@ static LogicalResult poolingInferReturnTypes(
   return success();
 }
 
-LogicalResult Conv2DOp::inferReturnTypeComponents(
-    MLIRContext *context, ::std::optional<Location> location,
-    Conv2DOp::Adaptor adaptor,
-    SmallVectorImpl<ShapedTypeComponents> &inferredReturnShapes) {
-  llvm::SmallVector<int64_t> outputShape(4, ShapedType::kDynamic);
+template <typename AdaptorT>
+class ConvInferShapeAdaptor;
 
-  int64_t inputWidth = ShapedType::kDynamic;
-  int64_t inputHeight = ShapedType::kDynamic;
-  int64_t weightWidth = ShapedType::kDynamic;
-  int64_t weightHeight = ShapedType::kDynamic;
-
-  // Input shape describes input width/height and batch.
+class ConvInferShapeAdaptorBase {
----------------
iliyan-georgiev-arm wrote:

Yeah I agree, it just stood out to me at the time. But from our offline conversation and the comment here a lot of it sounds like overkill and unnecessary.

So yeah looks good to me. It was just a nit anyway.

https://github.com/llvm/llvm-project/pull/178869