[Mlir-commits] [mlir] [mlirbc] Serialize dense elements attr i1 using packed (PR #182233)

[Jacques Pienaar]

================
@@ -465,6 +465,14 @@ class DialectWriter : public DialectBytecodeWriter {
         "dialect blob");
   }
 
+  void writeUnownedBlob(ArrayRef<char> blob) override {
+    emitter.emitVarInt(blob.size(), "dialect blob");
+    emitter.emitBytes(
+        ArrayRef<uint8_t>(reinterpret_cast<const uint8_t *>(blob.data()),
----------------
jpienaar wrote:

Here it is to be consistent with write unowned above in this change (didn't want to introduce any deviations). 

std::byte is C++17, so probably just predates much of these. Currently we are using char at top-level/dialect writer side, with uint8_t internally. So users should just be seeing char really. I wouldn't mind it being byte eventually, but it may end up propagating a few spots across multiple dialects and downstream consumers.

https://github.com/llvm/llvm-project/pull/182233