[Mlir-commits] [mlir] [OpenACC] add acc.combine operation (PR #181853)

[Razvan Lupusoru]

================
@@ -20,6 +20,47 @@
 // the necessary includes and definitions. The operations defined here use
 // types and definitions from that file.
 
+//===----------------------------------------------------------------------===//
+// acc.combine
+//===----------------------------------------------------------------------===//
+
+def OpenACC_CombineOp: OpenACC_Op<"combine", [SameTypeOperands, DeclareOpInterfaceMethods<MemoryEffectsOpInterface>]> {
----------------
razvanlupusoru wrote:

Can you rename this to acc.reduction_combine? Since reductions will get decomposed into multiple operations, including an "init" (which can't simply be acc.init due to the fact already such an operation exists) - thus all reduction operations should be named with "acc.reduction_". Thank you!

https://github.com/llvm/llvm-project/pull/181853