[Mlir-commits] [mlir] [mlir][vector] Clarify the semantics of gather/scatter indexing (nfc) (PR #181357)

[Krzysztof Drewniak]

krzysz00 wrote:

Re the "it only varies in the innermost dimension" (however we're phrasing that) - I'm not sure that's consistent with existing usage up in lowerings from `linalg`

That being said, I personally think that the high-level fix is to make the vector of offsets take K-tuples of indices (where 1 <= K < rank(base)`) that indicate the index to be gathered along in the each of the K trailing dimensions of the memref - where, for backwards compatibility and ergonomics, we omit the `x1` part of the `[out shape]x1xindex` that previous extension implies - and make that a canonical form).

https://github.com/llvm/llvm-project/pull/181357