[Mlir-commits] [mlir] [mlir][sparse][nfc] replace sparse_tensor.pointers in docs (PR #181636)

[llvmlistbot at llvm.org]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-mlir

Author: Vito Secona (secona)

<details>
<summary>Changes</summary>

The `-sparse-tensor-conversion` and `-sparse-tensor-codegen` descriptions use `sparse_tensor.pointers` which doesn't exist. I couldn't track the history, so I don't know if it was renamed or fully removed. This PR replaces said op into `sparse_tensor.positions`. It looks to have similar assembly format.

---
Full diff: https://github.com/llvm/llvm-project/pull/181636.diff


1 Files Affected:

- (modified) mlir/include/mlir/Dialect/SparseTensor/Transforms/Passes.td (+12-9) 


``````````diff
diff --git a/mlir/include/mlir/Dialect/SparseTensor/Transforms/Passes.td b/mlir/include/mlir/Dialect/SparseTensor/Transforms/Passes.td
index 0b8562e484f51..d0e265c2d72ad 100644
--- a/mlir/include/mlir/Dialect/SparseTensor/Transforms/Passes.td
+++ b/mlir/include/mlir/Dialect/SparseTensor/Transforms/Passes.td
@@ -257,7 +257,7 @@ def SparseTensorConversionPass : Pass<"sparse-tensor-conversion", "ModuleOp"> {
     ```mlir
       Before:
         func.func @foo(%arg0: tensor<8x8xf32, #CSR>) -> memref<?xindex> {
-          %0 = sparse_tensor.pointers %arg0 {dimension = 1 : index}
+          %0 = sparse_tensor.positions %arg0 {level = 1 : index}
              : tensor<8x8xf32, #CSR> to memref<?xindex>
           return %0 : memref<?xindex>
         }
@@ -265,7 +265,7 @@ def SparseTensorConversionPass : Pass<"sparse-tensor-conversion", "ModuleOp"> {
       After:
         func.func @foo(%arg0: !llvm.ptr) -> memref<?xindex> {
           %c1 = arith.constant 1 : index
-          %0 = call @sparsePointers0(%arg0, %c1)
+          %0 = call @sparsePositions0(%arg0, %c1)
              : (!llvm.ptr, index) -> memref<?xindex>
           return %0 : memref<?xindex>
         }
@@ -300,18 +300,21 @@ def SparseTensorCodegen : Pass<"sparse-tensor-codegen", "ModuleOp"> {
     ```mlir
       Before:
         func.func @foo(%arg0: tensor<8x8xf32, #CSR>) -> memref<?xindex> {
-          %0 = sparse_tensor.pointers %arg0 {dimension = 1 : index}
+          %0 = sparse_tensor.positions %arg0 {level = 1 : index}
              : tensor<8x8xf32, #CSR> to memref<?xindex>
           return %0 : memref<?xindex>
         }
 
       After:
-        func.func @foo(%arg0: memref<2xindex>,
-                       %arg1: memref<3xindex>,
-                       %arg2: memref<?xindex>,
-                       %arg3: memref<?xindex>,
-                       %arg4: memref<?xf32>) -> memref<?xindex> {
-          return %arg2 : memref<?xindex>
+        func.func @foo(%arg0: memref<?xindex>,
+                       %arg1: memref<?xindex>,
+                       %arg2: memref<?xf32>,
+                       %arg3: !sparse_tensor.storage_specifier<#sparse>) -> memref<?xindex> {
+          %0 = sparse_tensor.storage_specifier.get %arg3 pos_mem_sz at 1
+             : !sparse_tensor.storage_specifier<#sparse>
+          %subview = memref.subview %arg0[0] [%0] [1]
+                   : memref<?xindex> to memref<?xindex>
+          return %subview : memref<?xindex>
         }
     ```
   }];

``````````

</details>


https://github.com/llvm/llvm-project/pull/181636