[Mlir-commits] [mlir] [mlir][vector] add ApplyReorderMultiReductionDimsPatternsOp tests (PR #180977)

[Andrzej Warzyński]

https://github.com/banach-space commented:

Thanks for the updates!

> I normally comment below the reviewer's comment a link to a specific commit implementing the requested changes, but I now think that this is too verbose and would spam you. Let me know if you prefer I do that for the future PRs.

Including the commit SHA in PR replies is generally a high-quality way of addressing comments. It can make the review process more efficient and easier to follow. That said, it does add overhead and isn’t always practical (e.g. when comments are more open-ended or when changes are spread across multiple commits).

In some cases it can also add noise - especially when the PR already contains a number of incremental commits. There’s no strict requirement either way.

My rule of thumb is:

> If you were reviewing this change, would links to specific commits make it easier to follow?

Use your best judgment 🙂

Btw, could you remove tests for the patterns tested here from 
* "mlir/test/Dialect/Vector/vector-multi-reduction-lowering.mlir"

? Lets make sure there's no duplication.

Thank you again for working on this!

https://github.com/llvm/llvm-project/pull/180977