[Mlir-commits] [mlir] [mlir][spirv] Add 6 Element Binary operators to TOSA Ext Inst Set (PR #179627)

[Igor Wodiany]

================
@@ -431,3 +431,25 @@ spirv.ARM.Graph @clamp_max_val_different_element_type_wrt_input_output(%arg0: !s
   %3 = spirv.Tosa.Clamp min_val = -102 : i8, max_val = -100 : i16, nan_mode = <Propagate>, %arg0 : !spirv.arm.tensor<27x44x55xi8> -> !spirv.arm.tensor<27x44x55xi8>
   spirv.ARM.GraphOutputs %3 : !spirv.arm.tensor<27x44x55xi8>
 }
+
+//===----------------------------------------------------------------------===//
+// spirv.TOSA.Add
----------------
IgWod-IMG wrote:

I can see a value in repetition here; this allows us to change ops in isolation while still maintaining test coverage to catch potential failures. I don't think we should rely on a fact that all those ops use the same base and negative testing of only one is sufficient. I’m of the opinion that more coverage is better and duplicating those tests should be trivial.

https://github.com/llvm/llvm-project/pull/179627