[Mlir-commits] [mlir] [MLIR][Remark] Add remark linking and query-based related remarks (PR #180953)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Thu Feb 12 02:26:29 PST 2026
github-actions[bot] wrote:
<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results
* 3457 tests passed
* 413 tests skipped
* 2 tests failed
## Failed Tests
(click on a test name to see its output)
### MLIR
<details>
<summary>MLIR.Pass/remarks.mlir</summary>
```
Exit Code: 1
Command Output (stdout):
--
# RUN: at line 1
c:\_work\llvm-project\llvm-project\build\bin\mlir-opt.exe C:\_work\llvm-project\llvm-project\mlir\test\Pass\remarks.mlir --test-remark --remarks-filter-passed="category-1-passed" 2>&1 | c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe C:\_work\llvm-project\llvm-project\mlir\test\Pass\remarks.mlir -check-prefix=CHECK-PASSED
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\mlir-opt.exe' 'C:\_work\llvm-project\llvm-project\mlir\test\Pass\remarks.mlir' --test-remark --remarks-filter-passed=category-1-passed
# note: command had no output on stdout or stderr
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe' 'C:\_work\llvm-project\llvm-project\mlir\test\Pass\remarks.mlir' -check-prefix=CHECK-PASSED
# note: command had no output on stdout or stderr
# RUN: at line 2
c:\_work\llvm-project\llvm-project\build\bin\mlir-opt.exe C:\_work\llvm-project\llvm-project\mlir\test\Pass\remarks.mlir --test-remark --remarks-filter-missed="a-category-1-missed" 2>&1 | c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe C:\_work\llvm-project\llvm-project\mlir\test\Pass\remarks.mlir -check-prefix=CHECK-MISSED
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\mlir-opt.exe' 'C:\_work\llvm-project\llvm-project\mlir\test\Pass\remarks.mlir' --test-remark --remarks-filter-missed=a-category-1-missed
# note: command had no output on stdout or stderr
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe' 'C:\_work\llvm-project\llvm-project\mlir\test\Pass\remarks.mlir' -check-prefix=CHECK-MISSED
# note: command had no output on stdout or stderr
# RUN: at line 3
c:\_work\llvm-project\llvm-project\build\bin\mlir-opt.exe C:\_work\llvm-project\llvm-project\mlir\test\Pass\remarks.mlir --test-remark --remarks-filter-failed="category-2-failed" 2>&1 | c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe C:\_work\llvm-project\llvm-project\mlir\test\Pass\remarks.mlir -check-prefix=CHECK-FAILED
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\mlir-opt.exe' 'C:\_work\llvm-project\llvm-project\mlir\test\Pass\remarks.mlir' --test-remark --remarks-filter-failed=category-2-failed
# note: command had no output on stdout or stderr
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe' 'C:\_work\llvm-project\llvm-project\mlir\test\Pass\remarks.mlir' -check-prefix=CHECK-FAILED
# note: command had no output on stdout or stderr
# RUN: at line 4
c:\_work\llvm-project\llvm-project\build\bin\mlir-opt.exe C:\_work\llvm-project\llvm-project\mlir\test\Pass\remarks.mlir --test-remark --remarks-filter-analyse="category-2-analysis" 2>&1 | c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe C:\_work\llvm-project\llvm-project\mlir\test\Pass\remarks.mlir -check-prefix=CHECK-ANALYSIS
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\mlir-opt.exe' 'C:\_work\llvm-project\llvm-project\mlir\test\Pass\remarks.mlir' --test-remark --remarks-filter-analyse=category-2-analysis
# note: command had no output on stdout or stderr
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe' 'C:\_work\llvm-project\llvm-project\mlir\test\Pass\remarks.mlir' -check-prefix=CHECK-ANALYSIS
# note: command had no output on stdout or stderr
# RUN: at line 5
c:\_work\llvm-project\llvm-project\build\bin\mlir-opt.exe C:\_work\llvm-project\llvm-project\mlir\test\Pass\remarks.mlir --test-remark --remarks-filter="category.*" 2>&1 | c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe C:\_work\llvm-project\llvm-project\mlir\test\Pass\remarks.mlir -check-prefix=CHECK-ALL
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\mlir-opt.exe' 'C:\_work\llvm-project\llvm-project\mlir\test\Pass\remarks.mlir' --test-remark '--remarks-filter=category.*'
# note: command had no output on stdout or stderr
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe' 'C:\_work\llvm-project\llvm-project\mlir\test\Pass\remarks.mlir' -check-prefix=CHECK-ALL
# .---command stderr------------
# | C:\_work\llvm-project\llvm-project\mlir\test\Pass\remarks.mlir:24:15: error: CHECK-ALL: expected string not found in input
# | // CHECK-ALL: remark: [Passed]{{.*}}test-remark | Category:category-link |
# | ^
# | <stdin>:16:126: note: scanning from here
# | C:\_work\llvm-project\llvm-project\mlir\test\Pass\remarks.mlir:9:3: remark: [Analysis] test-remark | Category:category-link | Remark="Analysis that enables optimization"
# | ^
# | <stdin>:16:127: note: possible intended match here
# | C:\_work\llvm-project\llvm-project\mlir\test\Pass\remarks.mlir:9:3: remark: [Analysis] test-remark | Category:category-link | Remark="Analysis that enables optimization"
# | ^
# |
# | Input file: <stdin>
# | Check file: C:\_work\llvm-project\llvm-project\mlir\test\Pass\remarks.mlir
# |
# | -dump-input=help explains the following input dump.
# |
# | Input was:
# | <<<<<<
# | .
# | .
# | .
# | 11: "test.op"() : () -> ()
# | 12: ^
# | 13: C:\_work\llvm-project\llvm-project\mlir\test\Pass\remarks.mlir:9:3: remark: [Passed] test-remark | Category:category-link | Remark="Optimization enabled by analysis"
# | 14: "test.op"() : () -> ()
# | 15: ^
# | 16: C:\_work\llvm-project\llvm-project\mlir\test\Pass\remarks.mlir:9:3: remark: [Analysis] test-remark | Category:category-link | Remark="Analysis that enables optimization"
# | check:24'0 X~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ error: no match found
# | check:24'1 ? possible intended match
# | 17: "test.op"() : () -> ()
# | check:24'0 ~~~~~~~~~~~~~~~~~~~~~~~~
# | 18: ^
# | check:24'0 ~~~
# | 19: module @foo {
# | check:24'0 ~~~~~~~~~~~~~~
# | 20: "test.op"() : () -> ()
# | check:24'0 ~~~~~~~~~~~~~~~~~~~~~~~~
# | 21: }
# | check:24'0 ~~
# | 22:
# | check:24'0 ~
# | >>>>>>
# `-----------------------------
# error: command failed with exit status: 1
--
```
</details>
### MLIR-Unit
<details>
<summary>MLIR-Unit.IR/_/MLIRIRTests_exe/Remark/TestRemarkLinking</summary>
```
Script:
--
C:\_work\llvm-project\llvm-project\build\tools\mlir\unittests\IR\.\MLIRIRTests.exe --gtest_filter=Remark.TestRemarkLinking
--
C:\_work\llvm-project\llvm-project\mlir\unittests\IR\RemarkTest.cpp:552
Value of: static_cast<bool>(analysisId)
Actual: false
Expected: true
C:\_work\llvm-project\llvm-project\mlir\unittests\IR\RemarkTest.cpp:553
Expected: (analysisId.getValue()) > (0u), actual: 0 vs 0
C:\_work\llvm-project\llvm-project\mlir\unittests\IR\RemarkTest.cpp:566
Value of: errOut
Expected: has substring "RemarkId="
Actual: "Custom remark: [Passed] LoopOptimized | Category:Optimizer | @\"test.cpp\":10:5Remark=\"vectorized loop\"\nCustom remark: [Analysis] LoopAnalysis | Category:Optimizer | @\"test.cpp\":10:5Remark=\"analyzed loop with trip count 128\"\n"
C:\_work\llvm-project\llvm-project\mlir\unittests\IR\RemarkTest.cpp:569
Value of: errOut
Expected: has substring "RelatedTo="
Actual: "Custom remark: [Passed] LoopOptimized | Category:Optimizer | @\"test.cpp\":10:5Remark=\"vectorized loop\"\nCustom remark: [Analysis] LoopAnalysis | Category:Optimizer | @\"test.cpp\":10:5Remark=\"analyzed loop with trip count 128\"\n"
```
</details>
If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.
https://github.com/llvm/llvm-project/pull/180953
More information about the Mlir-commits
mailing list