[Mlir-commits] [mlir] [MLIR][Remark] Add remark linking and query-based related remarks (PR #180953)

[Guray Ozen]

grypp wrote:

> Thank you Guray. The idea seems useful. :)
> 
> On my side I had to adapt in one place: we use this framework to capture remarks and then print them in a user-visible way (we don't serialize them for now). So when your change started adding RemarkId (and RelatedTo) as args, this showed up in our output. To keep our messages unchanged, I added a filter in our streamer that skips those two keys when building the string we show to users (we hardcode "RemarkId" and "RelatedTo" for now). In future I may want to distinguish framework-specific args from those added by passes more generally. Anyway I appreciate you continue adding me as reviewer; because I was able to anticipate this issue, I have a solution ready to go and thus you're all good to move forward with this! :) Thank you!


Yes totally agree. We could make streamer configurable so frameworks can use it differently. 

fwiw, I also have my streamer in our downstream project :) We don't have any control over MLIR in general, so people can change the default streamer and printing mechanism. 

https://github.com/llvm/llvm-project/pull/180953