[Mlir-commits] [mlir] [mlir][shard, mpi] Allowing 2d-grids and simplifying lowering shard.all_gather (PR #180243)

[Adam Siemieniuk]

================
@@ -185,28 +201,24 @@ module attributes { mpi.dlti = #dlti.map<"MPI:comm_world_rank" = 7> } {
       // CHECK-SAME: [[varg0:%.*]]: memref<3x4xf32>
       // CHECK-SAME: -> memref<3x20xf32>
       %arg0 : memref<3x4xf32>) -> memref<3x20xf32> {
-    // CHECK-DAG: [[vc1_i32:%.*]] = arith.constant 1 : i32
-    // CHECK-DAG: [[vc2_i32:%.*]] = arith.constant 2 : i32
-    // CHECK-DAG: [[vc20:%.*]] = arith.constant 20 : index
+    // CHECK: [[vc2_i32:%.*]] = arith.constant 2 : i32
----------------
adam-smnk wrote:

nit: I'd keep `-DAG` for constants and also add it in the new test case's checks

https://github.com/llvm/llvm-project/pull/180243