[Mlir-commits] [mlir] [mlir][tensor]-Handle Dynamic Offset in BubbleUpSliceOpThroughCollapse (PR #178921)
ofri frishman
llvmlistbot at llvm.org
Mon Feb 9 23:57:39 PST 2026
================
----------------
ofri-frishman wrote:
`currentOffsetDivisor * currentCollapsedsize` Is equal to `staticSize.value()` and even in the comment in line 720 it is stated that the offset should be a multiple of the slice size, It would be clearer to just use `staticSize.value()` here since it isn't apparent at first glance that they are equal, and that way the code would better match the documentation.
https://github.com/llvm/llvm-project/pull/178921
More information about the Mlir-commits
mailing list