[Mlir-commits] [mlir] [milr][memref]: Add control options to FoldMemrefAliasOps (PR #178405)

[llvmlistbot at llvm.org]

MaheshRavishankar wrote:

> To be honest it's still not clear to me why we allow these control functions in many other similar patterns in MLIR, but for this specific pattern they are considered an "unnecessary overhead".

Thats fair point. I think everywhere they exist within patterns is not the recommended way, but we have some legacy patterns that do that. No one has gone back and cleaned those up. 

>  However it's not that important, so I can just abandon this if it's deemed not useful

I think its not that it isnt useful. I think you are trying to control which patterns you want to run and doing that by adding the control function into each pattern that is added to the populate list. The other approach would be to just not add those patterns to begin with. You can do this through managing the `populate*` methods to break it up from a monolith into more coherent pieces. 

https://github.com/llvm/llvm-project/pull/178405