[Mlir-commits] [mlir] [mlir][memref]-Add verification for MemRef::ViewOp bounds (PR #177778)

[Amir Bishara]

amirBish wrote:

> We shouldn't be verifying non-local properties loke constant values https://mlir.llvm.org/getting_started/DeveloperGuide/#ir-verifier

Thanks @kuhar for the reply, In this commit I'm adding a check for the sizes attribute mentioned in the operation itself without climbing for the def-use chain, It is the same approach already being done in the SubviewOp to validate in bounds sizes/offsets/strides. Would be glad to hear why this case is different and mainly why such a check shouldn't be included within the operation's invariants (specifically where all of our attributes are static). 

https://github.com/llvm/llvm-project/pull/177778