[Mlir-commits] [clang] [mlir] [CIR] Add tons of function infra, plus a handful of attributes (PR #179811)

[Henrich Lauko]

================
@@ -2009,6 +2014,11 @@ def LLVM_LLVMFuncOp : LLVM_Op<"func", [
     OptionalAttr<StrAttr>:$modular_format,
     OptionalAttr<ArrayAttr>:$nobuiltins,
     OptionalAttr<DenseI32ArrayAttr>:$allocsize,
+    OptionalAttr<UnitAttr>:$optsize,
+    OptionalAttr<UnitAttr>:$minsize,
+    OptionalAttr<UnitAttr>:$save_reg_params,
----------------
xlauko wrote:

Any reason these are `OptionalAttr<UnitAttr>` here and just `UnitAttr` on functions? I believe `UnitAttr` is enough since it is either just present or not?



https://github.com/llvm/llvm-project/pull/179811