[Mlir-commits] [mlir] [mlir][Interface] Allow scalar operands and require ranked shaped operands in IndexingMapOpInterface (PR #179072)

[Stefan Weigl-Bosker]

sweiglbosker wrote:

> Maybe the checks should be added to a verifier for GenericOp? Iirc IndexingMapOpInterface is supposed to be polymorphic for shaped types in general (I think this was done with iree in mind, maybe check how they use it?). As for in-tree, i think vector.contract also uses it, so the "only memref and tensor" constraint wouldnt work.

Did you look into this? I kind of like the idea of type checking linalg.generic, then calling IndexingMapOpInterface->verifyImpl from that, like vector.contract does. I dont think that IndexingMapOpInterface needs to be limited to specific builtin types

https://github.com/llvm/llvm-project/pull/179072