[Mlir-commits] [mlir] [MLIR] Fix use-after-free in Remark by owning string data (PR #179889)

[llvmlistbot at llvm.org]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

* 3452 tests passed
* 413 tests skipped
* 1 test failed

## Failed Tests
(click on a test name to see its output)

### MLIR-Unit
<details>
<summary>MLIR-Unit.IR/_/MLIRIRTests_exe/Remark/TestRemarkOwnsStringData</summary>

```
Script:
--
C:\_work\llvm-project\llvm-project\build\tools\mlir\unittests\IR\.\MLIRIRTests.exe --gtest_filter=Remark.TestRemarkOwnsStringData
--
C:\_work\llvm-project\llvm-project\mlir\unittests\IR\RemarkTest.cpp:481
Expected: (errOut.find(expectedCategory)) != (std::string::npos), actual: 18446744073709551615 vs 18446744073709551615
Expected category not found in output. Got: 

C:\_work\llvm-project\llvm-project\mlir\unittests\IR\RemarkTest.cpp:483
Expected: (errOut.find(expectedName)) != (std::string::npos), actual: 18446744073709551615 vs 18446744073709551615
Expected name not found in output. Got: 

C:\_work\llvm-project\llvm-project\mlir\unittests\IR\RemarkTest.cpp:485
Expected: (errOut.find(expectedFunction)) != (std::string::npos), actual: 18446744073709551615 vs 18446744073709551615
Expected function not found in output. Got: 

C:\_work\llvm-project\llvm-project\mlir\unittests\IR\RemarkTest.cpp:487
Expected: (errOut.find(expectedMessage)) != (std::string::npos), actual: 18446744073709551615 vs 18446744073709551615
Expected message not found in output. Got: 


```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/179889