[Mlir-commits] [mlir] [mlir][spirv] Add Element Binary operators to TOSA Ext Inst Set (PR #179627)

[Jakub Kuderski]

kuhar wrote:

> Would it be possible to create parent ops for binary and unary operations and then use them to implement the actual new ops? Currently there is a lot of repetition, e.g., `getInput1Type`. It's a fairly common pattern for other types of ops, e.g.,
> 
> https://github.com/llvm/llvm-project/blob/a631f3e434b41471aa9f852f23bbc1d0ab4fa7bd/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVNonUniformOps.td#L26

+1. Can you also split this into a few smaller PRs (ideally <= 500 kLOC each)?

https://github.com/llvm/llvm-project/pull/179627