[Mlir-commits] [mlir] [mlir] Return from equals overload (PR #179655)

[llvmlistbot at llvm.org]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-mlir

@llvm/pr-subscribers-mlir-execution-engine

Author: Ilgar Gamidov (braam-76)

<details>
<summary>Changes</summary>

Closes [#<!-- -->91233](https://github.com/llvm/llvm-project/issues/91233)

mlir/include/mlir/ExecutionEngine/MemRefUtils.h:190:No 'return' statement in non-void function

---
Full diff: https://github.com/llvm/llvm-project/pull/179655.diff


1 Files Affected:

- (modified) mlir/include/mlir/ExecutionEngine/MemRefUtils.h (+2-1) 


``````````diff
diff --git a/mlir/include/mlir/ExecutionEngine/MemRefUtils.h b/mlir/include/mlir/ExecutionEngine/MemRefUtils.h
index e9471731afe13..c160a34207b2f 100644
--- a/mlir/include/mlir/ExecutionEngine/MemRefUtils.h
+++ b/mlir/include/mlir/ExecutionEngine/MemRefUtils.h
@@ -186,11 +186,12 @@ class OwningMemRef {
   }
   OwningMemRef(const OwningMemRef &) = delete;
   OwningMemRef &operator=(const OwningMemRef &) = delete;
-  OwningMemRef &operator=(const OwningMemRef &&other) {
+  OwningMemRef &operator=(OwningMemRef &&other) {
     freeFunc = other.freeFunc;
     descriptor = other.descriptor;
     other.freeFunc = nullptr;
     memset(&other.descriptor, 0, sizeof(other.descriptor));
+    return *this;
   }
   OwningMemRef(OwningMemRef &&other) { *this = std::move(other); }
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/179655