[Mlir-commits] [mlir] [mlir][vector] Wrapping `populateFlattenVectorTransferPatterns` as a transform pass. (PR #178134)

[Andrzej Warzyński]

================

----------------
banach-space wrote:

Please avoid creating dedicated test files for TD Ops. If we did that for every set of patterns, we would basically double the number of test files - that would be unmaintainable.

Instead, could you add a new `RUN` line to test files that already exercise patterns from `populateFlattenVectorTransferPatterns`? From a quick search, that would be files that run [TestVectorReduceToContractPatternsPatterns](https://github.com/llvm/llvm-project/blob/02804501af9c764126964a965c02dbee84690227/mlir/test/lib/Dialect/Vector/TestVectorTransforms.cpp?plain=1#L409-L427), e.g. https://github.com/llvm/llvm-project/blob/02804501af9c764126964a965c02dbee84690227/mlir/test/Dialect/Vector/drop-unit-dims-with-shape-cast.mlir?plain=1

There might be more, please double check.

https://github.com/llvm/llvm-project/pull/178134