[Mlir-commits] [mlir] [mlir][emitc] Update and extend the TOSA -> EmitC test (PR #177339)
Andrzej Warzyński
llvmlistbot at llvm.org
Mon Feb 2 07:02:28 PST 2026
https://github.com/banach-space updated https://github.com/llvm/llvm-project/pull/177339
>From 54b0f8a805656de649466f9fcffcd700141a5aad Mon Sep 17 00:00:00 2001
From: Andrzej Warzynski <andrzej.warzynski at arm.com>
Date: Thu, 22 Jan 2026 10:31:04 +0000
Subject: [PATCH 1/3] [mlir][emitc] Update and extend the TOSA -> EmitC test
This patch updates and extends the TOSA-to-EmitC lowering test:
* Conversion/ConvertToEmitC/tosa.mlir
Summary of changes and rationale:
* Remove `buffer-alignment=0` from the lowering pipeline; it is not required
(the existing `CHECK` lines are not affected).
* Move the test from Conversion/ConvertToEmitC/tosa.mlir to
Dialect/EmitC/tosa/ops.mlir. Conversion tests are intended for single
conversion passes (e.g. `-convert-dialect1-to-dialect2`), whereas this
test exercises a more complex lowering pipeline with multiple explicit
steps (e.g. TOSA -> Linalg, bufferization, etc.).
* Add a Transform Dialect sequence to complement the existing lowering
pipeline definition. This introduces an additional `RUN` line that is
compatible with the original one. Using the Transform Dialect makes the
pipeline easier to document, maintain, and experiment with.
---
mlir/test/Dialect/EmitC/tosa/lit.local.cfg | 2 +
.../tosa.mlir => Dialect/EmitC/tosa/ops.mlir} | 10 +++--
mlir/test/Dialect/EmitC/tosa/td.mlir | 42 +++++++++++++++++++
3 files changed, 50 insertions(+), 4 deletions(-)
create mode 100644 mlir/test/Dialect/EmitC/tosa/lit.local.cfg
rename mlir/test/{Conversion/ConvertToEmitC/tosa.mlir => Dialect/EmitC/tosa/ops.mlir} (79%)
create mode 100644 mlir/test/Dialect/EmitC/tosa/td.mlir
diff --git a/mlir/test/Dialect/EmitC/tosa/lit.local.cfg b/mlir/test/Dialect/EmitC/tosa/lit.local.cfg
new file mode 100644
index 0000000000000..848972126d7e8
--- /dev/null
+++ b/mlir/test/Dialect/EmitC/tosa/lit.local.cfg
@@ -0,0 +1,2 @@
+# Skip files with TD sequences that are used for RUN lines
+config.excludes = ["td.mlir"]
diff --git a/mlir/test/Conversion/ConvertToEmitC/tosa.mlir b/mlir/test/Dialect/EmitC/tosa/ops.mlir
similarity index 79%
rename from mlir/test/Conversion/ConvertToEmitC/tosa.mlir
rename to mlir/test/Dialect/EmitC/tosa/ops.mlir
index 158018374e72c..9f08a95438dfe 100644
--- a/mlir/test/Conversion/ConvertToEmitC/tosa.mlir
+++ b/mlir/test/Dialect/EmitC/tosa/ops.mlir
@@ -5,7 +5,6 @@
// DEFINE: one-shot-bufferize{\
// DEFINE: bufferize-function-boundaries\
// DEFINE: function-boundary-type-conversion=identity-layout-map\
-// DEFINE: buffer-alignment=0\
// DEFINE: },\
// DEFINE: buffer-results-to-out-params{\
// DEFINE: hoist-static-allocs=true\
@@ -18,9 +17,12 @@
// DEFINE: )"
// RUN: mlir-opt --pass-pipeline=%{pipeline} %s | FileCheck %s
-// -----
-// CHECK: emitc.func private @main(%[[ARG0:.*]]: !emitc.array<2xf32>, %[[ARG1:.*]]: !emitc.array<2xf32>, %[[RES:.*]]: !emitc.array<2xf32>)
+// RUN: mlir-opt -split-input-file \
+// RUN: -transform-preload-library='transform-library-paths=%p/td.mlir' \
+// RUN: -transform-interpreter %s -test-transform-dialect-erase-schedule | mlir-opt -convert-to-emitc | FileCheck %s
+
+// CHECK: emitc.func private @add(%[[ARG0:.*]]: !emitc.array<2xf32>, %[[ARG1:.*]]: !emitc.array<2xf32>, %[[RES:.*]]: !emitc.array<2xf32>)
// CHECK-DAG: %[[C0:.*]] = "emitc.constant"() <{value = 0 : index}> : () -> !emitc.size_t
// CHECK-DAG: %[[C1:.*]] = "emitc.constant"() <{value = 1 : index}> : () -> !emitc.size_t
// CHECK-DAG: %[[C2:.*]] = "emitc.constant"() <{value = 2 : index}> : () -> !emitc.size_t
@@ -35,7 +37,7 @@
// CHECK-NEXT: }
// CHECK-NEXT: return
// CHECK-NEXT: }
-func.func private @main(%arg0: tensor<2xf32>, %arg1: tensor<2xf32>) -> tensor<2xf32> {
+func.func private @add(%arg0: tensor<2xf32>, %arg1: tensor<2xf32>) -> tensor<2xf32> {
%0 = tosa.add %arg0, %arg1 : (tensor<2xf32>, tensor<2xf32>) -> tensor<2xf32>
return %0 : tensor<2xf32>
}
diff --git a/mlir/test/Dialect/EmitC/tosa/td.mlir b/mlir/test/Dialect/EmitC/tosa/td.mlir
new file mode 100644
index 0000000000000..59b93de2f805e
--- /dev/null
+++ b/mlir/test/Dialect/EmitC/tosa/td.mlir
@@ -0,0 +1,42 @@
+module attributes {transform.with_named_sequence} {
+ transform.named_sequence @__transform_main(%module:
+ !transform.any_op{transform.consumed}) {
+ // 1. TOSA --> Linalg
+ %func_h_1 = transform.structured.match ops{["func.func"]} in %module : (!transform.any_op) -> !transform.any_op
+ transform.apply_registered_pass "tosa-to-linalg"
+ to %func_h_1 : (!transform.any_op) -> !transform.any_op
+
+ // 2. Bufferize
+ // As per BufferizationEnums.td, value 1 for `LayoutMapOption` corresponds
+ // to `IdentityLayoutMap`.
+ %module_bufferized = transform.bufferization.one_shot_bufferize %module
+ { bufferize_function_boundaries=true,
+ function_boundary_type_conversion = 1 : i32}
+ : (!transform.any_op) -> !transform.op<"builtin.module">
+
+ // 3. Apply BufferResultsToOutParams - otherwise the following error is raised:
+ // * "error: 'emitc.func' op cannot return array type"
+ // "hoist-static-allocs" is an optional optimization step.
+ %func_h_2 = transform.structured.match ops{["func.func"]} in %module_bufferized : (!transform.op<"builtin.module">) -> !transform.any_op
+ %module_h_1 = transform.get_parent_op %func_h_2 {isolated_from_above} : (!transform.any_op) -> !transform.any_op
+ %module_results_as_out_param = transform.apply_registered_pass "buffer-results-to-out-params"
+ with options = { "hoist-static-allocs" = true }
+ to %module_h_1 : (!transform.any_op) -> !transform.any_op
+
+ %module_final_no_linalg = transform.apply_registered_pass "convert-linalg-to-loops"
+ to %module_results_as_out_param : (!transform.any_op) -> !transform.any_op
+
+ // 4. Canonicalize - not strictly required
+ transform.apply_patterns to %module_final_no_linalg {
+ transform.apply_patterns.canonicalization
+ } : !transform.any_op
+
+ // FIXME: This causes a crash, which implies a bug
+ // %func_h_3 = transform.structured.match ops{["func.func"]} in %module_final_no_linalg
+ // : (!transform.any_op) -> !transform.any_op
+ // transform.apply_registered_pass "convert-to-emitc" to %func_h_3
+ // : (!transform.any_op) -> !transform.op<"func.func">
+
+ transform.yield
+ }
+}
>From 9099b737b1098d9ca4c1217a3854add184886557 Mon Sep 17 00:00:00 2001
From: Andrzej Warzynski <andrzej.warzynski at arm.com>
Date: Thu, 22 Jan 2026 20:09:02 +0000
Subject: [PATCH 2/3] Enable EmitC conversion in TD seq
---
mlir/test/Dialect/EmitC/tosa/ops.mlir | 2 +-
mlir/test/Dialect/EmitC/tosa/td.mlir | 10 +++++-----
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/mlir/test/Dialect/EmitC/tosa/ops.mlir b/mlir/test/Dialect/EmitC/tosa/ops.mlir
index 9f08a95438dfe..d232224109e7a 100644
--- a/mlir/test/Dialect/EmitC/tosa/ops.mlir
+++ b/mlir/test/Dialect/EmitC/tosa/ops.mlir
@@ -20,7 +20,7 @@
// RUN: mlir-opt -split-input-file \
// RUN: -transform-preload-library='transform-library-paths=%p/td.mlir' \
-// RUN: -transform-interpreter %s -test-transform-dialect-erase-schedule | mlir-opt -convert-to-emitc | FileCheck %s
+// RUN: -transform-interpreter %s -test-transform-dialect-erase-schedule | FileCheck %s
// CHECK: emitc.func private @add(%[[ARG0:.*]]: !emitc.array<2xf32>, %[[ARG1:.*]]: !emitc.array<2xf32>, %[[RES:.*]]: !emitc.array<2xf32>)
// CHECK-DAG: %[[C0:.*]] = "emitc.constant"() <{value = 0 : index}> : () -> !emitc.size_t
diff --git a/mlir/test/Dialect/EmitC/tosa/td.mlir b/mlir/test/Dialect/EmitC/tosa/td.mlir
index 59b93de2f805e..65fc8e9c6e554 100644
--- a/mlir/test/Dialect/EmitC/tosa/td.mlir
+++ b/mlir/test/Dialect/EmitC/tosa/td.mlir
@@ -31,11 +31,11 @@ module attributes {transform.with_named_sequence} {
transform.apply_patterns.canonicalization
} : !transform.any_op
- // FIXME: This causes a crash, which implies a bug
- // %func_h_3 = transform.structured.match ops{["func.func"]} in %module_final_no_linalg
- // : (!transform.any_op) -> !transform.any_op
- // transform.apply_registered_pass "convert-to-emitc" to %func_h_3
- // : (!transform.any_op) -> !transform.op<"func.func">
+ %func_h_3 = transform.structured.match ops{["func.func"]} in %module_final_no_linalg
+ : (!transform.any_op) -> !transform.any_op
+ %module_h_2 = transform.get_parent_op %func_h_3 {isolated_from_above} : (!transform.any_op) -> !transform.any_op
+ transform.apply_registered_pass "convert-to-emitc" to %module_h_2
+ : (!transform.any_op) -> !transform.op<"builtin.module">
transform.yield
}
>From fcb3295f4b788762695578007a5151552b60b820 Mon Sep 17 00:00:00 2001
From: Andrzej Warzynski <andrzej.warzynski at arm.com>
Date: Mon, 2 Feb 2026 15:02:11 +0000
Subject: [PATCH 3/3] Restore the original version
---
mlir/test/Dialect/EmitC/tosa/ops.mlir | 2 +-
mlir/test/Dialect/EmitC/tosa/td.mlir | 12 +++++++-----
2 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/mlir/test/Dialect/EmitC/tosa/ops.mlir b/mlir/test/Dialect/EmitC/tosa/ops.mlir
index d232224109e7a..9f08a95438dfe 100644
--- a/mlir/test/Dialect/EmitC/tosa/ops.mlir
+++ b/mlir/test/Dialect/EmitC/tosa/ops.mlir
@@ -20,7 +20,7 @@
// RUN: mlir-opt -split-input-file \
// RUN: -transform-preload-library='transform-library-paths=%p/td.mlir' \
-// RUN: -transform-interpreter %s -test-transform-dialect-erase-schedule | FileCheck %s
+// RUN: -transform-interpreter %s -test-transform-dialect-erase-schedule | mlir-opt -convert-to-emitc | FileCheck %s
// CHECK: emitc.func private @add(%[[ARG0:.*]]: !emitc.array<2xf32>, %[[ARG1:.*]]: !emitc.array<2xf32>, %[[RES:.*]]: !emitc.array<2xf32>)
// CHECK-DAG: %[[C0:.*]] = "emitc.constant"() <{value = 0 : index}> : () -> !emitc.size_t
diff --git a/mlir/test/Dialect/EmitC/tosa/td.mlir b/mlir/test/Dialect/EmitC/tosa/td.mlir
index 65fc8e9c6e554..97bb878dc7945 100644
--- a/mlir/test/Dialect/EmitC/tosa/td.mlir
+++ b/mlir/test/Dialect/EmitC/tosa/td.mlir
@@ -31,11 +31,13 @@ module attributes {transform.with_named_sequence} {
transform.apply_patterns.canonicalization
} : !transform.any_op
- %func_h_3 = transform.structured.match ops{["func.func"]} in %module_final_no_linalg
- : (!transform.any_op) -> !transform.any_op
- %module_h_2 = transform.get_parent_op %func_h_3 {isolated_from_above} : (!transform.any_op) -> !transform.any_op
- transform.apply_registered_pass "convert-to-emitc" to %module_h_2
- : (!transform.any_op) -> !transform.op<"builtin.module">
+ // FIXME: This causes a crash, hence its commented out. See:
+ // * https://github.com/llvm/llvm-project/issues/179247
+ // %func_h_3 = transform.structured.match ops{["func.func"]} in %module_final_no_linalg
+ // : (!transform.any_op) -> !transform.any_op
+ // %module_h_2 = transform.get_parent_op %func_h_3 {isolated_from_above} : (!transform.any_op) -> !transform.any_op
+ // transform.apply_registered_pass "convert-to-emitc" to %module_h_2
+ // : (!transform.any_op) -> !transform.op<"builtin.module">
transform.yield
}
More information about the Mlir-commits
mailing list