[Mlir-commits] [mlir] [MLIR][NVVM] Add binaryCallback (PR #170853)

[Mehdi Amini]

================
@@ -521,6 +524,15 @@ NVPTXSerializer::compileToBinary(const std::string &ptxCode) {
                                                 /*ErrMsg=*/&message))
     return emitLogError("`fatbinary`");
 
+  if (binaryCallback) {
+    llvm::ErrorOr<std::unique_ptr<llvm::MemoryBuffer>> logBuffer =
+        llvm::MemoryBuffer::getFile(logFile->first);
+    if (logBuffer && !(*logBuffer)->getBuffer().empty()) {
+      StringRef logRef = (*logBuffer)->getBuffer();
+      binaryCallback(logRef);
----------------
joker-eph wrote:

> Could you please suggest a path forward to get this PR landed? 

I did though!
This is fundamentally a diagnostic, it should use the diagnostic / remark infra IMO.

> it’s been hard to make progress without a clear use case.

Well if there is no clear use-case, maybe we can just close this then?

https://github.com/llvm/llvm-project/pull/170853