[Mlir-commits] [mlir] [mlir][linalg] Fix linalg.select crash with index type operands (PR #179056)
Renato Golin
llvmlistbot at llvm.org
Mon Feb 2 01:29:39 PST 2026
https://github.com/rengolin requested changes to this pull request.
I'm calling this PR into question for the following reasons:
1. While it's true that the op definition allows `AnyType`, there isn't a single real test of index in the payload shape across the tests that I could find. This begs the question: is this really a reasonable usage of `index` type?
2. The undisclosed usage of automated accounts / process to generate issues (fuzzer? LLM?) and PRs.
In the past, people have added corner cases to some ops and not others, generating a precedent that later was unclear if we had to propagate to other ops or remove the old code. Since this would be the first case I can see of this being exercised, I think we need to make sure we want to do that and design for that across the dialect.
https://github.com/llvm/llvm-project/pull/179056
More information about the Mlir-commits
mailing list