[Mlir-commits] [mlir] [mlir][LivenessAnalysis] Remove unnecessary addDependency on results (PR #179149)

[llvmlistbot at llvm.org]

neildhar wrote:

I found it confusing that (for all callers of `visitOperation` in this analysis), `addDependency` is only being used to record a dependency between an op and its own result. Because as far as I can tell, that is always handled by the framework, and seems like a very natural thing for the framework to do.

> we call visitOperation multiple times within LivenessAnalysis

I think that's a reasonable argument for keeping this as is. Is your concern about guarding against theoretical future changes, or do you have concrete cases where this would break? Either way, if the consensus here is that we should be defensive and avoid this change, I don't feel strongly.

https://github.com/llvm/llvm-project/pull/179149