[Mlir-commits] [mlir] Fix #177829 mlir-opt --convert-vector-to-llvm crashes on vector.insert with out-of-bounds index (PR #179116)

[llvmlistbot at llvm.org]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- mlir/lib/Conversion/VectorToLLVM/ConvertVectorToLLVM.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/mlir/lib/Conversion/VectorToLLVM/ConvertVectorToLLVM.cpp b/mlir/lib/Conversion/VectorToLLVM/ConvertVectorToLLVM.cpp
index b404260be..a1132a937 100644
--- a/mlir/lib/Conversion/VectorToLLVM/ConvertVectorToLLVM.cpp
+++ b/mlir/lib/Conversion/VectorToLLVM/ConvertVectorToLLVM.cpp
@@ -1237,23 +1237,25 @@ public:
     ArrayRef<OpFoldResult> positionOf1DVectorWithinAggregate(
         positionVec.begin(),
         insertIntoInnermostDim ? positionVec.size() - 1 : positionVec.size());
-    
+
     if (isNestedAggregate) {
       std::optional<SmallVector<int64_t>> maybeAggPos;
       maybeAggPos =
           mlir::getConstantIntValues(positionOf1DVectorWithinAggregate);
       if (!maybeAggPos) {
         return rewriter.notifyMatchFailure(
-            insertOp, "non-constant aggregate position for extract/insertvalue");
+            insertOp,
+            "non-constant aggregate position for extract/insertvalue");
       }
 
       // Bounds check against the aggregate dimensions we index into.
-      for (int64_t i = 0, e = static_cast<int64_t>(maybeAggPos->size()); i < e; ++i) {
+      for (int64_t i = 0, e = static_cast<int64_t>(maybeAggPos->size()); i < e;
+           ++i) {
         int64_t idx = (*maybeAggPos)[i];
         int64_t dim = destVectorType.getDimSize(i);
         if (idx < 0 || idx >= dim) {
-          return rewriter.notifyMatchFailure(insertOp,
-                                            "out-of-bounds aggregate position");
+          return rewriter.notifyMatchFailure(
+              insertOp, "out-of-bounds aggregate position");
         }
       }
     }

``````````

</details>


https://github.com/llvm/llvm-project/pull/179116