[Mlir-commits] [mlir] [mlir][affine] Fix inverted epilogue check in affineForOpBodySkew (PR #217553)

[Alessandro Potenza]

https://github.com/alepot55 commented:

The description says it plainly now, thanks.

This looks right to me. GitHub will not let me press Approve without repository access, so for the record, here is what that would have meant: I read the surrounding function and the state the branch selects is producible, because the first loop can set `prologue` and `epilogue` from the same `res` and the trailing `opGroupQueue` loop can then reassign `epilogue` to a null result while `prologue` stays set. `unrollPrologueEpilogue` defaults to `false` and `PipelineDataTransfer.cpp` is the only in-tree caller, so neither unroll call is reachable through a pass. I built `11e915f2b75d` with the patch and `mlir/test/Dialect/Affine` is 72 of 72, unchanged, which is what an unreachable path should look like.

@bondhugula, this needs someone with commit access, both to approve it and to land it.

https://github.com/llvm/llvm-project/pull/217553