[Mlir-commits] [mlir] [mlir][affine] Fix inverted epilogue check in affineForOpBodySkew (PR #217553)

[Alessandro Potenza]

alepot55 wrote:

Update the description. My comment stays on the PR, but LLVM squashes the description into the commit message, so someone reading `git log` in a year gets only what you wrote there, and the sentence they will need is the one about no in-tree caller.

Two short paragraphs are enough:

> `!epilogue` is inverted. The branch fires only when there is no epilogue, so it passes a null `AffineForOp` to `loopUnrollFull`, and a real epilogue is never unrolled. The prologue line just above already has the correct shape.
>
> No test accompanies this: `unrollPrologueEpilogue` defaults to `false` in `LoopUtils.h`, and the only in-tree caller of `affineForOpBodySkew`, `PipelineDataTransfer.cpp`, does not pass it, so neither unroll call is reachable through any pass.

And drop the "my understanding is". You are right about the code; saying it plainly makes it easier to approve, not harder.


https://github.com/llvm/llvm-project/pull/217553