[Mlir-commits] [mlir] [mlir][shard] Bounds-check the axis attributes in the collective verifiers (PR #219691)

[Alessandro Potenza]

alepot55 wrote:

Done, thanks. `slice_axis` for `all_slice`, `scatter_dim` for `scatter` and `reduce_scatter`, `split_axis` and `concat_axis` for `all_to_all`.

Worth saying why that needed a parameter rather than just a better string. `verifyScatterOrSliceOperandAndResultShape` is shared by three ops whose attribute is not spelled the same way, so the one generic word was standing in for two different names. It now takes the name and prints it verbatim, and the six negative tests pin the exact text.

`verifyGatherOperandAndResultShape` still says "Gather axis", which tracks `gather_axis` closely enough that I left it alone rather than widen the diff. Say the word if you would rather have it aligned here.

For the record: I force-pushed a few minutes ago. The first push accidentally carried two unrelated files out of my working tree, which is also why the PR briefly went `dirty`. `224c6722c` is the intended change, two files, and `buildkite/libcxx-ci` is green on it.

I do not have commit access, so it needs someone to land it: `Alessandro Potenza <ap.alessandro.potenza at gmail.com>`.


https://github.com/llvm/llvm-project/pull/219691