[Mlir-commits] [mlir] [mlir] Add emitRemark overload taking ArrayRef<Twine> (PR #217804)

[lonely eagle]

================

----------------
linuxlonelyeagle wrote:

* Appending newlines using the `append` method certainly produces cleaner output. However, it introduces another issue: it makes verification difficult, as we end up having to check extremely long single lines. It also doesn't look great in test files.
* If we split remarks across multiple lines, it's actually much clearer in the test files. We can check each remark individually instead of having to verify everything all at once (which gets too long). You can see following.
```
  // expected-remark at +3 {{[n0] -> { R0[d0, d1] -> W0[d0' = d1, d1' = d0] : 0 < d0 < n0 and d1 > d0 and 0 < d1 < n0; R0[d0, d1 = d0] -> W0[d0' = d0, d1' = d0] : 0 < d0 < n0 }}}
  // expected-remark at +2 {{[n0] -> { W0[d0, d1] -> R0[d0' = d1, d1' = d0] : 0 < d0 < n0 and d1 > d0 and 0 < d1 < n0 }}
  // expected-remark at +1 {{[n0] -> { W0[d0, d1] -> R1[d0' = d0, d1' = 1 + d1] : 0 <= d0 < n0 and 0 < d1 <= -2 + n0 }}}
  affine.for %i = 0 to %arg1 {
    affine.for %j = 1 to %arg1 {
```

https://github.com/llvm/llvm-project/pull/217804