[Mlir-commits] [mlir] [MLIR][OpenMP] Replace target-data assert with error (PR #219228)

[Sergio Afonso]

https://github.com/skatrak created https://github.com/llvm/llvm-project/pull/219228

If a user incorrectly puts a `target data`, `target enter data`, `target exit data` or `target update` directive inside of target device code, this will get lowered to MLIR and trigger an assert while translating the corresponding operations to LLVM IR.

Part of the issue is that there are no semantics checks to prevent this but, even if they were added, they wouldn't be able to incorporate implicit `declare target` information, as that is added later. This patch replaces the assert with a more informative compile error during MLIR to LLVM IR translation to catch any of these cases that make it past semantics.

>From e1a5d6069d398c11cdc810da6b009eba5789a1a6 Mon Sep 17 00:00:00 2001
From: Sergio Afonso <Sergio.AfonsoFumero at amd.com>
Date: Thu, 27 Aug 2026 16:08:24 +0100
Subject: [PATCH] [MLIR][OpenMP] Replace target-data assert with error

If a user incorrectly puts a `target data`, `target enter data`, `target exit
data` or `target update` directive inside of target device code, this will get
lowered to MLIR and trigger an assert while translating the corresponding
operations to LLVM IR.

Part of the issue is that there are no semantics checks to prevent this but,
even if they were added, they wouldn't be able to incorporate implicit `declare
target` information, as that is added later. This patch replaces the assert
with a more informative compile error during MLIR to LLVM IR translation to
catch any of these cases that make it past semantics.
---
 .../OpenMP/OpenMPToLLVMIRTranslation.cpp      |  6 ++++--
 .../Target/LLVMIR/openmp-llvm-invalid.mlir    | 19 +++++++++++++++++++
 2 files changed, 23 insertions(+), 2 deletions(-)

diff --git a/mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp b/mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp
index f5e579eaa023e..9c8575ed706ec 100644
--- a/mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp
+++ b/mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp
@@ -8327,8 +8327,10 @@ convertOmpTargetData(Operation *op, llvm::IRBuilderBase &builder,
   llvm::OpenMPIRBuilder::TargetDataInfo info(
       /*RequiresDevicePointerInfo=*/true,
       /*SeparateBeginEndCalls=*/true);
-  assert(!ompBuilder->Config.isTargetDevice() &&
-         "target data/enter/exit/update are host ops");
+
+  if (ompBuilder->Config.isTargetDevice())
+    return op->emitOpError() << "not allowed in a target device";
+
   bool isOffloadEntry = !ompBuilder->Config.TargetTriples.empty();
 
   auto getDeviceID = [&](mlir::Value dev) -> llvm::Value * {
diff --git a/mlir/test/Target/LLVMIR/openmp-llvm-invalid.mlir b/mlir/test/Target/LLVMIR/openmp-llvm-invalid.mlir
index 0c0ea9dd17b64..641e803dba5d9 100644
--- a/mlir/test/Target/LLVMIR/openmp-llvm-invalid.mlir
+++ b/mlir/test/Target/LLVMIR/openmp-llvm-invalid.mlir
@@ -187,3 +187,22 @@ module attributes {llvm.target_triple = "amdgcn-amd-amdhsa", omp.is_target_devic
     llvm.return
   }
 }
+
+// -----
+
+module attributes {llvm.target_triple = "amdgcn-amd-amdhsa", omp.is_target_device = true} {
+  llvm.func @target_data_in_device(%arg0 : !llvm.ptr) attributes {omp.declare_target = #omp.declaretarget<device_type = (any), capture_clause = (enter)>} {
+    %0 = omp.map.info var_ptr(%arg0 : !llvm.ptr, !llvm.array<1024 x i32>) map_clauses(tofrom) capture(ByRef) name("") -> !llvm.ptr
+    // expected-error @below {{op not allowed in a target device}}
+    omp.target_data map_entries(%0 : !llvm.ptr) {
+      omp.terminator
+    }
+    // expected-error @below {{op not allowed in a target device}}
+    omp.target_update map_entries(%0 : !llvm.ptr)
+    // expected-error @below {{op not allowed in a target device}}
+    omp.target_enter_data map_entries(%0 : !llvm.ptr)
+    // expected-error @below {{op not allowed in a target device}}
+    omp.target_exit_data map_entries(%0 : !llvm.ptr)
+    llvm.return
+  }
+}