[Mlir-commits] [flang] [mlir] [mlir][OpenACC][OpenMP] Use explicit attribute APIs (PR #218901)

[Sergio Afonso]

================
@@ -12,9 +12,10 @@ func.func @critical_block_arg() {
   // CHECK-NEXT: ^[[BB0:.*]](%[[ARG1:.*]]: i64, %[[ARG2:.*]]: i64):
   ^bb0(%arg1: index, %arg2: index):
     // CHECK-NEXT: llvm.call @foo(%[[ARG1]], %[[ARG2]]) : (i64, i64) -> ()
+    // CHECK: } {test.discardable}
     func.call @foo(%arg1, %arg2) : (index, index) -> ()
     omp.terminator
-  }
+  } {test.discardable}
----------------
skatrak wrote:

Nit: Why is this added here? If the intent is to make sure other dialect's discardable attributes aren't lost, maybe it makes more sense to add another `func.func` where that feature is tested on its own.

https://github.com/llvm/llvm-project/pull/218901