[Mlir-commits] [mlir] [mlir] Remove dead forward declarations (PR #218863)

[llvmlistbot at llvm.org]

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-mlir-linalg

Author: Kazu Hirata (kazutakahirata)

<details>
<summary>Changes</summary>

This patch removes forward declarations of classes and structs that
are no longer referenced anywhere in MLIR.


---
Full diff: https://github.com/llvm/llvm-project/pull/218863.diff


5 Files Affected:

- (modified) mlir/include/mlir/Dialect/Affine/Analysis/AffineStructures.h (-1) 
- (modified) mlir/include/mlir/Dialect/GPU/TransformOps/Utils.h (-1) 
- (modified) mlir/include/mlir/Dialect/IRDL/IR/IRDL.h (-8) 
- (modified) mlir/include/mlir/Dialect/LLVMIR/LLVMDialect.h (-5) 
- (modified) mlir/include/mlir/Dialect/Linalg/TransformOps/LinalgTransformOps.h (-1) 


``````````diff
diff --git a/mlir/include/mlir/Dialect/Affine/Analysis/AffineStructures.h b/mlir/include/mlir/Dialect/Affine/Analysis/AffineStructures.h
index 49903c3c3f672..963d3e5324220 100644
--- a/mlir/include/mlir/Dialect/Affine/Analysis/AffineStructures.h
+++ b/mlir/include/mlir/Dialect/Affine/Analysis/AffineStructures.h
@@ -33,7 +33,6 @@ class MultiAffineFunction;
 } // namespace presburger
 
 namespace affine {
-class AffineCondition;
 class AffineForOp;
 class AffineIfOp;
 class AffineParallelOp;
diff --git a/mlir/include/mlir/Dialect/GPU/TransformOps/Utils.h b/mlir/include/mlir/Dialect/GPU/TransformOps/Utils.h
index 9cbdfd2fa218c..0fc1537dbfdb9 100644
--- a/mlir/include/mlir/Dialect/GPU/TransformOps/Utils.h
+++ b/mlir/include/mlir/Dialect/GPU/TransformOps/Utils.h
@@ -17,7 +17,6 @@
 
 namespace mlir {
 namespace gpu {
-class GPUOp;
 class LaunchOp;
 enum class MappingId : uint64_t;
 } // namespace gpu
diff --git a/mlir/include/mlir/Dialect/IRDL/IR/IRDL.h b/mlir/include/mlir/Dialect/IRDL/IR/IRDL.h
index 0e72cee3c6e87..5e95307f550e3 100644
--- a/mlir/include/mlir/Dialect/IRDL/IR/IRDL.h
+++ b/mlir/include/mlir/Dialect/IRDL/IR/IRDL.h
@@ -22,14 +22,6 @@
 
 #include <memory>
 
-// Forward declaration.
-namespace mlir {
-namespace irdl {
-class OpDef;
-class OpDefAttr;
-} // namespace irdl
-} // namespace mlir
-
 //===----------------------------------------------------------------------===//
 // IRDL Dialect
 //===----------------------------------------------------------------------===//
diff --git a/mlir/include/mlir/Dialect/LLVMIR/LLVMDialect.h b/mlir/include/mlir/Dialect/LLVMIR/LLVMDialect.h
index f3bd5c090803d..5ebfbcde7a272 100644
--- a/mlir/include/mlir/Dialect/LLVMIR/LLVMDialect.h
+++ b/mlir/include/mlir/Dialect/LLVMIR/LLVMDialect.h
@@ -45,11 +45,6 @@ class SmartMutex;
 namespace mlir {
 namespace LLVM {
 class LLVMDialect;
-
-namespace detail {
-struct LLVMTypeStorage;
-struct LLVMDialectImpl;
-} // namespace detail
 } // namespace LLVM
 } // namespace mlir
 
diff --git a/mlir/include/mlir/Dialect/Linalg/TransformOps/LinalgTransformOps.h b/mlir/include/mlir/Dialect/Linalg/TransformOps/LinalgTransformOps.h
index 9ede21e87cf53..b3468dd0027ad 100644
--- a/mlir/include/mlir/Dialect/Linalg/TransformOps/LinalgTransformOps.h
+++ b/mlir/include/mlir/Dialect/Linalg/TransformOps/LinalgTransformOps.h
@@ -26,7 +26,6 @@ class RewriterBase;
 
 namespace linalg {
 class CopyOp;
-struct ForallTilingResult;
 class GenericOp;
 class LinalgOp;
 } // namespace linalg

``````````

</details>


https://github.com/llvm/llvm-project/pull/218863