[Mlir-commits] [mlir] [mlir][LLVM] Preserve !associated and !absolute_symbol on llvm.mlir.global (PR #218839)

[llvmlistbot at llvm.org]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp mlir/lib/Target/LLVMIR/ModuleImport.cpp mlir/lib/Target/LLVMIR/ModuleTranslation.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/mlir/lib/Target/LLVMIR/ModuleImport.cpp b/mlir/lib/Target/LLVMIR/ModuleImport.cpp
index 46b09aa5b..9f26c3240 100644
--- a/mlir/lib/Target/LLVMIR/ModuleImport.cpp
+++ b/mlir/lib/Target/LLVMIR/ModuleImport.cpp
@@ -1693,7 +1693,8 @@ LogicalResult ModuleImport::convertGlobal(llvm::GlobalVariable *globalVar) {
         llvm::Value *value = valueAsMD->getValue();
         llvm::GlobalValue *gv = dyn_cast<llvm::GlobalValue>(value);
         if (!gv)
-          gv = dyn_cast<llvm::GlobalValue>(value->stripPointerCastsAndAliases());
+          gv =
+              dyn_cast<llvm::GlobalValue>(value->stripPointerCastsAndAliases());
         if (gv) {
           StringRef name = gv->getName();
           FlatSymbolRefAttr symbolRef;
@@ -1714,8 +1715,8 @@ LogicalResult ModuleImport::convertGlobal(llvm::GlobalVariable *globalVar) {
           globalVar->getMetadata(llvm::LLVMContext::MD_absolute_symbol)) {
     SmallVector<Attribute> rangeAttrs;
     rangeAttrs.reserve(absSymMD->getNumOperands());
-    bool valid = absSymMD->getNumOperands() >= 2 &&
-                 absSymMD->getNumOperands() % 2 == 0;
+    bool valid =
+        absSymMD->getNumOperands() >= 2 && absSymMD->getNumOperands() % 2 == 0;
     for (const llvm::MDOperand &op : absSymMD->operands()) {
       auto *constInt = llvm::mdconst::dyn_extract<llvm::ConstantInt>(op);
       if (!constInt) {

``````````

</details>


https://github.com/llvm/llvm-project/pull/218839