[Mlir-commits] [mlir] [mlir][linalg] Support subtracting accumulation in partial reduction … (PR #214033)

Renato Golin llvmlistbot at llvm.org
Tue Aug 25 03:58:04 PDT 2026


================
@@ -561,11 +635,12 @@ struct LinalgOpPartialReductionInterface
           combinerOps.size() != 1)
         return op->emitOpError("Failed to anaysis the reduction operation.");
 
-      Operation *reductionOp = combinerOps[0];
-      std::optional<TypedAttr> identity = arith::getNeutralElement(reductionOp);
-      if (!identity.has_value())
+      std::optional<SplitReductionCombiner> combiner =
----------------
rengolin wrote:

No need to get the whole reduction combiner just for the neutral element attribute. You don't use the `combiner` anywhere else in this function (neither did the previous code).

https://github.com/llvm/llvm-project/pull/214033


More information about the Mlir-commits mailing list