[Mlir-commits] [mlir] [mlir][linalg] Support subtracting accumulation in partial reduction … (PR #214033)

Renato Golin llvmlistbot at llvm.org
Tue Aug 25 03:58:01 PDT 2026


================
@@ -723,18 +798,24 @@ struct LinalgOpPartialReductionInterface
         }
       }
 
+      // Get the combiner op. This has to happen before the merge operation is
+      // built, since the region builder below cannot report a failure.
----------------
rengolin wrote:

This comment is AI slop. You're just replacing the old code with a function call. Moving the check outside doesn't change it.

https://github.com/llvm/llvm-project/pull/214033


More information about the Mlir-commits mailing list