[Mlir-commits] [mlir] [MLIR][Arith] Don't narrow shifts whose amount can exceed the target width (PR #218495)

[llvmlistbot at llvm.org]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

* 4078 tests passed
* 446 tests skipped
* 1 test failed

## Failed Tests
(click on a test name to see its output)

### MLIR
<details>
<summary>MLIR.Dialect/Vector/vector-unroll-options.mlir</summary>

```
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
c:\_work\llvm-project\llvm-project\build\bin\mlir-opt.exe C:\_work\llvm-project\llvm-project\mlir\test\Dialect\Vector\vector-unroll-options.mlir -test-vector-unrolling-patterns=unroll-based-on-type -split-input-file | c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe C:\_work\llvm-project\llvm-project\mlir\test\Dialect\Vector\vector-unroll-options.mlir
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\mlir-opt.exe' 'C:\_work\llvm-project\llvm-project\mlir\test\Dialect\Vector\vector-unroll-options.mlir' -test-vector-unrolling-patterns=unroll-based-on-type -split-input-file
# note: command had no output on stdout or stderr
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe' 'C:\_work\llvm-project\llvm-project\mlir\test\Dialect\Vector\vector-unroll-options.mlir'
# .---command stderr------------
# | C:\_work\llvm-project\llvm-project\mlir\test\Dialect\Vector\vector-unroll-options.mlir:878:11: error: CHECK: expected string not found in input
# | // CHECK: %[[E0:.*]] = vector.extract_strided_slice %{{.*}} {offsets = [0, 0, 0], sizes = [1, 2, 2], strides = [1, 1, 1]} : vector<2x2x4xf32> to vector<1x2x2xf32>
# |           ^
# | <stdin>:726:61: note: scanning from here
# |  %cst = arith.constant dense<0.000000e+00> : vector<2x2xf32>
# |                                                             ^
# | <stdin>:726:61: note: pattern attempts to capture variables: "E0"
# |  %cst = arith.constant dense<0.000000e+00> : vector<2x2xf32>
# |                                                             ^
# | <stdin>:727:2: note: possible intended match here
# |  %0 = vector.extract_strided_slice %arg0 offsets = [0, 0, 0], sizes = [1, 2, 2], strides = [1, 1, 1] : vector<2x2x4xf32> to vector<1x2x2xf32>
# |  ^
# | 
# | Input file: <stdin>
# | Check file: C:\_work\llvm-project\llvm-project\mlir\test\Dialect\Vector\vector-unroll-options.mlir
# | 
# | -dump-input=help explains the following input dump.
# | 
# | Input was:
# | <<<<<<
# |              .
# |              .
# |              .
# |            721: } 
# |            722:  
# |            723: // ----- 
# |            724: module { 
# |            725:  func.func @vector_multi_reduction_rank_mismatch(%arg0: vector<2x2x4xf32>, %arg1: vector<2x2xf32>) -> vector<2x2xf32> { 
# |            726:  %cst = arith.constant dense<0.000000e+00> : vector<2x2xf32> 
# | check:878'0                                                                {   search range start (exclusive)
# | check:878'1                                                                    error: no match found in search range
# | check:878'2                                                                    pattern attempts to capture variables: "E0"
# |            727:  %0 = vector.extract_strided_slice %arg0 offsets = [0, 0, 0], sizes = [1, 2, 2], strides = [1, 1, 1] : vector<2x2x4xf32> to vector<1x2x2xf32> 
# | check:878'3      ?                                                                                                                                              possible intended match
# |            728:  %1 = vector.extract_strided_slice %arg1 offsets = [0, 0], sizes = [1, 2], strides = [1, 1] : vector<2x2xf32> to vector<1x2xf32> 
# |            729:  %2 = vector.multi_reduction <add>, %0, %1 [2] : vector<1x2x2xf32> to vector<1x2xf32> 
# |            730:  %3 = vector.extract_strided_slice %arg0 offsets = [0, 0, 2], sizes = [1, 2, 2], strides = [1, 1, 1] : vector<2x2x4xf32> to vector<1x2x2xf32> 
# |            731:  %4 = vector.multi_reduction <add>, %3, %2 [2] : vector<1x2x2xf32> to vector<1x2xf32> 
# |            732:  %5 = vector.extract_strided_slice %arg0 offsets = [1, 0, 0], sizes = [1, 2, 2], strides = [1, 1, 1] : vector<2x2x4xf32> to vector<1x2x2xf32> 
# |              .
# |              .
# |              .
# |            737:  %10 = vector.insert_strided_slice %4, %cst offsets = [0, 0], strides = [1, 1] : vector<1x2xf32> into vector<2x2xf32> 
# |            738:  %11 = vector.insert_strided_slice %9, %10 offsets = [1, 0], strides = [1, 1] : vector<1x2xf32> into vector<2x2xf32> 
# |            739:  return %11 : vector<2x2xf32> 
# |            740:  } 
# |            741: } 
# |            742:  
# | check:878'4      } search range end (exclusive)
# | >>>>>>
# `-----------------------------
# error: command failed with exit status: 1

--

```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/218495