[Mlir-commits] [mlir] [mlir:arm:tests] Add back `REQUIRED` tag removed by #216098. (PR #218447)

Ingo Müller llvmlistbot at llvm.org
Mon Aug 24 09:01:54 PDT 2026


https://github.com/ingomueller-net created https://github.com/llvm/llvm-project/pull/218447

The recent #216098 changed which features are used to select with ARM-related tests are run. Among other things, it removed the `REQUIRED` tag of one of the LIT files, `mlir/test/Integration/Dialect/Linalg/CPU/ArmNeon/matmul-i8.mlir`. That test, however, requires the `mcr_aarch64_cmd` substitution, which isn't available always. This PR adds back the tag with the `mlir_arm_neon_tests` feature, which *does* provide the necessary substitution and which seems to be the tag typically used for ARM Neon tests.

>From 208877bc1aecd99ca53b5249555747d83f0ae416 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ingo=20M=C3=BCller?= <ingomueller at google.com>
Date: Mon, 24 Aug 2026 17:57:23 +0200
Subject: [PATCH] [mlir:arm:tests] Add back `REQUIRED` tag removed by #216098.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The recent #216098 changed which features are used to select with
ARM-related tests are run. Among other things, it removed the `REQUIRED`
tag of one of the LIT files,
`mlir/test/Integration/Dialect/Linalg/CPU/ArmNeon/matmul-i8.mlir`. That
test, however, requires the `mcr_aarch64_cmd` substitution, which isn't
available always. This PR adds back the tag with the
`mlir_arm_neon_tests` feature, which *does* provide the necessary
substitution and which seems to be the tag typically used for ARM Neon
tests.

Signed-off-by: Ingo Müller <ingomueller at google.com>
---
 mlir/test/Integration/Dialect/Linalg/CPU/ArmNeon/matmul-i8.mlir | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/mlir/test/Integration/Dialect/Linalg/CPU/ArmNeon/matmul-i8.mlir b/mlir/test/Integration/Dialect/Linalg/CPU/ArmNeon/matmul-i8.mlir
index 1a6f315cd2da4..d824208e33741 100644
--- a/mlir/test/Integration/Dialect/Linalg/CPU/ArmNeon/matmul-i8.mlir
+++ b/mlir/test/Integration/Dialect/Linalg/CPU/ArmNeon/matmul-i8.mlir
@@ -1,3 +1,5 @@
+// REQUIRES: mlir_arm_neon_tests
+
 // DEFINE: %{compile} = mlir-opt %s \
 // DEFINE:   -transform-interpreter -test-transform-dialect-erase-schedule \
 // DEFINE:   -cse -canonicalize -convert-vector-to-scf \



More information about the Mlir-commits mailing list