[Mlir-commits] [mlir] [mlir][Vector] Fix out-of-bounds crash unrolling create_mask/constant_mask with rank-mismatched native shape (PR #217514)

[Hamza Qureshi]

hamzaqureshi5 wrote:

Thanks @amanyagami

+1 to the leading unit dims approach @banach-space  — I tried it locally and the semantics do
hold, and it keeps this consistent with UnrollElementwisePattern.

One gotcha on constant_mask: tiles that fall entirely outside the mask get a
zero in one dim, which the op rejects ("expected all mask dim sizes to be zeros,
as a result of conjunction with zero mask dim"). Normalizing a zero dim to all
zeros sorts it.

And +1 to @FedericoBruzzone on the tests — they flip from "the op is left alone" to
checking the unrolled output, so the two new cases will need rewriting.


https://github.com/llvm/llvm-project/pull/217514