[Mlir-commits] [mlir] [MLIR][TOSA] Enable strict property assembly format (PR #217291)

Luke Hutton llvmlistbot at llvm.org
Fri Aug 21 09:47:11 PDT 2026


================
@@ -6174,5 +5876,20 @@ LogicalResult tosa::SliceShapeOp::verify() {
 // TOSA Operator Definitions.
 //===----------------------------------------------------------------------===//
 
+static ParseResult parseBoolAttr(OpAsmParser &parser, BoolAttr &result) {
----------------
lhutton1 wrote:

Happy to leave this as optional but it seems as though this custom parsing of BoolAttr can be avoided by updating `parseOptionalAttribute` ([link](https://github.com/llvm/llvm-project/blob/f7f6e6f4011252d3aacd44e87dd07c263049aad1/mlir/include/mlir/IR/OpImplementation.h#L1175)) to handle attributes without an `AttrType::name`

https://github.com/llvm/llvm-project/pull/217291


More information about the Mlir-commits mailing list