[Mlir-commits] [mlir] [mlir] Make symbol-user type verification proportional to participating IR (PR #212354)

[Will Dietz]

dtzSiFive wrote:

Hi folks! Thanks for the great work here!

I'll respond soon with some additional feedback/thoughts, but to avoid very high costs to ourselves and other users while we work on sorting out the verification strategy, I've opened a PR to back out this interface.

This crosses the threshold for (blameless) revert due to performance regressions, and our users and specifically CIRCT need to use a recent LLVM (without a 2-3x slowdown, YMMV) in the interim when they use the very common SymbolTable infrastructure.

We can reland it once we get this squared away; I'm optimistic we can get this within noise or at least single-digit when there's no work to be done generally but let's see what we can figure out and how we'd like to move forward with this.

https://github.com/llvm/llvm-project/pull/217959

https://github.com/llvm/llvm-project/pull/212354