[Mlir-commits] [mlir] [MLIR][LLVM] Support DWARF v6 source language names in DICompileUnitAttr (PR #217432)

[Gibran Essa]

gibwrong wrote:

> Looks like I managed to not post the question in the morning :), so here it is:
> 
> Did you try to avoid the custom printing and parsing for the source language? Would that require a lot of test changes?
> 
> I am asking since avoiding custom printers and parser is generally good practice.

Doing so was an attempt to keep reverse compatibility without much changes. Removing the custom parser/printer would require changing an additional 36 test files, do you think that is preferred?

https://github.com/llvm/llvm-project/pull/217432