[Mlir-commits] [lldb] [llvm] [mlir] [DebugInfo] Add symbolic branches to DIExpression (PR #210850)

[Eric Christopher]

echristo wrote:


> That possibility, coupled with valid review concerns going unmentioned by several reviewers just feels like something that needs to be addressed.
> 

I addressed every single comment, including yours on the review. Some of them that required code were going to take longer - especially as "split this out" was part of the requests.

> I can definitely see us hashing out a higher-level path in an RFC that involves more fundamental work, while still deciding that a local change with caveats like this one is reasonable to go forward with in the mean-time. I do think we should aim to limit the "conceptual fallout" from that local change, in any case.
> 
> I am again not trying to just hold up progress for the sake of it, and I don't imagine anyone else who had/has reservations about this patch have that goal either.

I still don't necessarily agree that this is a required step for something usable as it changes nothing about DIExpression to use. If you want to add on such facilities later we can talk about how to design those in.

https://github.com/llvm/llvm-project/pull/210850