[Mlir-commits] [mlir] [mlir][memref] Enforce consistent reinterpret_cast metadata (PR #217338)

[Igor Wodiany]

================
@@ -488,30 +488,33 @@ func.func @reinterpret_cast(%arg: memref<?xf32, #spirv.storage_class<CrossWorkgr
 //       CHECK:  %[[RET:.*]] = spirv.InBoundsPtrAccessChain %[[MEM1]][%[[OFF1]]] : !spirv.ptr<f32, CrossWorkgroup>, i32
 //       CHECK:  %[[RET1:.*]] = builtin.unrealized_conversion_cast %[[RET]] : !spirv.ptr<f32, CrossWorkgroup> to memref<?xf32, strided<[1], offset: ?>, #spirv.storage_class<CrossWorkgroup>>
 //       CHECK:  return %[[RET1]]
-  %ret = memref.reinterpret_cast %arg to offset: [%arg1], sizes: [10], strides: [1] : memref<?xf32, #spirv.storage_class<CrossWorkgroup>> to memref<?xf32, strided<[1], offset: ?>, #spirv.storage_class<CrossWorkgroup>>
----------------
IgWod wrote:

What is the exact impact of keeping `10` as a literal value? Does it fail the conversion or produces a completely different output? If the latter we should have test for both cases, if former, then I guess that's it.

https://github.com/llvm/llvm-project/pull/217338