[Mlir-commits] [mlir] [MLIR][OpenMP] Add verifier to prevent illegal omp.critical nesting (PR #217357)

[Aidan Dakhama]

dakaidan wrote:

 Thanks for the quick review @tblah. To clarify, the specification says nested critical regions cannot have the same name, this is section 17.2:
> A critical region must not be nested (closely or otherwise) inside a critical region with the same name. This restriction is not sufficient to prevent deadlock


And yes, you're right, this cannot catch any dynamically nested critical regions, this is intended to be a verifier for statically malformed nesting. 

https://github.com/llvm/llvm-project/pull/217357