[Mlir-commits] [mlir] [mlir][VectorToSCF] Decline transfer ops with no automatic allocation scope (PR #216947)

[Federico Bruzzone]

================
@@ -908,3 +908,19 @@ func.func @negative_scalable_transpose_store_3(%vec: vector<[4]x4xf32>, %dest: m
 }
 // FULL-UNROLL-LABEL: @negative_scalable_transpose_store_3
 // FULL-UNROLL-NOT:   scf.for
+
+// -----
+
+// Negative test: lowering a transfer op whose rank exceeds the target rank
+// allocates a temporary buffer, which requires an enclosing automatic
+// allocation scope. These ops sit directly in the implicit `builtin.module`,
+// which is not one, so the pattern declines and the transfer op is left alone.
----------------
FedericoBruzzone wrote:

I don't want to sound annoying:'D

```suggestion
// Negative test: lowering a transfer op whose rank exceeds the target rank
// allocates a temporary buffer, which requires an enclosing automatic
// allocation scope.
```

https://github.com/llvm/llvm-project/pull/216947