[Mlir-commits] [mlir] [mlir] Avoid removing returns for mismatch call results (PR #207587)

[Akimasa Watanuki]

Men-cotton wrote:

You're right, the default implementation of `getForwardedResults` is sufficient. My phrasing was imprecise.

The actual issue is that `test.call_and_store` does not invoke `call_interface_impl::verifyCallOpInterface` as part of its verification. As a result, the mismatch between the callee results and the call op's forwarded results is not diagnosed before the IR reaches `RemoveDeadValues`.

https://github.com/llvm/llvm-project/pull/207587