[Mlir-commits] [mlir] [MLIR] Document the OperationState properties invariant (PR #216686)

[Sylvestre Ledru]

sylvestre wrote:

Reworked per @dwblaikie / @joker-eph: dropped the ADT change entirely and instead documented the invariant in `OperationState` with a narrow `// coverity[uninit_member]` suppression.

@aengelke re: `function_ref::operator==` — good catch that it is only used by `FunctionRefTest`, and it is arguably wrong anyway since it ignores `callback`. Since this PR no longer touches ADT, I left it alone here; happy to send removing it as a separate PR.

(The earlier macOS CI failure was infra — PyPI returning 502s while installing numpy.)

https://github.com/llvm/llvm-project/pull/216686