[Mlir-commits] [mlir] [MLIR][OpenMP] Support for dispatch construct with clauses nocontext & novariants (PR #215877)

[Abid Qadeer]

================

----------------
abidh wrote:

Could you spell out what the `nocontext` and `novariants` operands mean at the dialect level? As I understand the plan, the frontend resolves the base/variant choice while it builds the region. Flang reads these operands back off the enclosing op during call lowering. By translation time they carry no remaining semantics and are correctly ignored. That's a reasonable split, but it isn't visible from this PR alone. The clause descriptions added here state the full spec semantics ("no function variant is selected for the target call of the dispatch region, even if one would be selected normally"), and those strings become the generated OpenMP dialect documentation. The `omp.dispatch novariants(%c)` currently reads as a promise the dialect doesn't keep. Two sentences on the op saying something like "the producer of the region is responsible for materializing the base/variant selection, and the LLVM IR translation deliberately ignores these operands" would stop anyone reading them as silently dropped clauses.

https://github.com/llvm/llvm-project/pull/215877