[Mlir-commits] [mlir] [mlir][linalg] Support subtracting accumulation in partial reduction … (PR #214033)

[Ege Beysel]

egebeysel wrote:

> What I mean by blocked is mostly the former, i.e., I think we should first establish what the current tiling infrastructure actually does when the combiner has nsw/nuw flags.

The current tiling infrastructure currently just clones the operation, and the corresponding overflow flags with it. It does not really handle it. I think we should not block this going in regardless, and take the most feasible approach that is consistent with the rest of the existing mechanisms. In my opinion, _dropping_ the flags or blocking partial reduction tiling, as well as just carrying-over the flags are feasible and consistent with what exists.

I would honestly just copy-over the flags, create the issue, raise it, and tackle this once the discussion is settled, at least not implement it in the scope of this PR, to have a consistent state after this PR is merged. It hasn't bothered anyone till now, I doubt it will soon.

https://github.com/llvm/llvm-project/pull/214033